search result links and cleans up the unused variables in layout.jsx#2369
Open
Adi-Codes-well wants to merge 1 commit intojenkins-infra:mainfrom
Open
search result links and cleans up the unused variables in layout.jsx#2369Adi-Codes-well wants to merge 1 commit intojenkins-infra:mainfrom
Adi-Codes-well wants to merge 1 commit intojenkins-infra:mainfrom
Conversation
Contributor
|
As per https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/a#technical_summary it's not allowed to have We could do one/both of
|
Adi-Codes-well
changed the title
Author
|
Currently, I have replaced the outer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2352
PR Title: feat: Allow search results to open in new tab and fix lint warnings
This PR fixes the search result links and cleans up the unused variables in layout.jsx.
Currently, the search result items on the plugin index page are rendered as div elements with an onClick handler. This prevents users from using standard browser functionality like middle-clicking or Ctrl+Click to open plugin pages in a new tab, which is frustrating for users who want to compare multiple plugins.
This change replaces the div with a standard HTML tag, restoring the expected browser behavior and improving usability.
Fix video.zip
The layout.jsx component contained two unused variables (buildTime and siteUrl) that were triggering ESLint no-unused-vars warnings during development. This change removes the unused variables, cleaning up the code and resolving the linting errors.